Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Building process will be broken if add -latomic in Mac with Clang. #109

Merged
merged 4 commits into from
Nov 19, 2022

Conversation

liu-kan
Copy link
Contributor

@liu-kan liu-kan commented Aug 21, 2022

Although a quick fix existed at
#107
But according to
nodejs/node#30099
this one is better.

deets and others added 3 commits August 21, 2022 12:09
@liu-kan liu-kan closed this Aug 21, 2022
@liu-kan liu-kan reopened this Aug 21, 2022
@codypiersall
Copy link
Owner

Thanks for this PR!

@codypiersall codypiersall merged commit 8b79d6b into codypiersall:master Nov 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants